Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oscommands: use a pty for stderr #2674

Closed
wants to merge 1 commit into from

Conversation

oliverpool
Copy link

@oliverpool oliverpool commented May 25, 2023

  • PR Description

Currently making remote operations with a secure-key-backed ssh key will shows the following output in the terminal:

notifiy_start: exec(/usr/lib/ssh/ssh-askpass): No such file or directory

2023-05-25-213844

With this PR, it will show:

Confirm user presence for key ...

2023-05-25-213346

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@oliverpool
Copy link
Author

This is my first PR for this project and first experience with PTYs (I had to dig quite a lot to understand the wrong Git output).

Let me know if this workaround makes sense and if my implementation looks sensible!

Thank you for starting and maintaining this great project!

@oliverpool
Copy link
Author

Maybe this workaround should be disabled for windows?


I just realized that self.getCmdHandler a couple of lines below is also creating a pty. Maybe this function could support this usecase as well 🤔

@oliverpool
Copy link
Author

I am in the process of switching to a tpm-backed ssh key: #4018

(Hence not much interested in finishing this)

@oliverpool oliverpool closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant