Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more options to log graph view #2380

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shinhs0506
Copy link
Contributor

  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@mark2185
Copy link
Collaborator

The Config.md needs updating as well, and this isn't backwards compatible.

lazygit fails to start if someone already has the allBranchesLogCmd in their config.yml, e.g.:

git:
  allBranchesLogCmd: 'git log --graph --all'

Running lazygit:

$> lazygit
2023/01/19 11:37:28 The config at `/home/mark/.config/lazygit/config.yml` couldn't be parsed, please inspect it before opening up an issue.
yaml: unmarshal errors:
  line 2: cannot unmarshal !!str `git log...` into config.AllBranchesLogCmdConfig
exit status 1

@shinhs0506
Copy link
Contributor Author

@mark2185 would it be better to just toggle between the curr log graph and the oneline version (instead of being able to cycle through once we do have more than 2 options) ?

@mark2185
Copy link
Collaborator

This seems more fitting for a custom command than a breaking change.

And toggling between one configurable and one hardcoded version doesn't sound that useful, if that's what you had in mind?

@shinhs0506
Copy link
Contributor Author

i was thinking toggling between 2 hardcoded versions

@mark2185
Copy link
Collaborator

But then we're losing the ability to configure it without building from source.

If neither of the two versions fit someone's needs, what are they supposed to do?

@shinhs0506
Copy link
Contributor Author

oh i meant hardcoded as in users can provide the command string in the config.yml, and we just add another one for the oneline verion. my bad

@mark2185
Copy link
Collaborator

Okay, I could see that working.

I guess it would be a handy feature to have one custom log, and one compact.

But, I have to wonder - how many people actually need that? Given that we have the ability to execute custom commands, this seems that would better suit that approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch between multiple log views
2 participants