-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more options to log graph view #2380
base: master
Are you sure you want to change the base?
Conversation
9032a95
to
e09747b
Compare
The Config.md needs updating as well, and this isn't backwards compatible.
Running
|
@mark2185 would it be better to just toggle between the curr log graph and the oneline version (instead of being able to cycle through once we do have more than 2 options) ? |
This seems more fitting for a custom command than a breaking change. And toggling between one configurable and one hardcoded version doesn't sound that useful, if that's what you had in mind? |
i was thinking toggling between 2 hardcoded versions |
But then we're losing the ability to configure it without building from source. If neither of the two versions fit someone's needs, what are they supposed to do? |
oh i meant hardcoded as in users can provide the command string in the |
Okay, I could see that working. I guess it would be a handy feature to have one But, I have to wonder - how many people actually need that? Given that we have the ability to execute custom commands, this seems that would better suit that approach. |
PR Description
fixes Switch between multiple log views #1363
press
a
to cycle through differentlog graph
viewsPlease check if the PR fulfills these requirements
go run scripts/cheatsheet/main.go generate
)docs/Config.md
) have been updated if necessary