Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lazycore utils: Clamp and GetLazyRootDirectory #2223

Merged

Conversation

gusandrioli
Copy link
Contributor

@gusandrioli gusandrioli commented Oct 15, 2022

  • PR Description
    This PR updates some functions to start using lazycore's utils. This changes all instances of GetLazygitRootDirectory and one instance of Clamp to avoid conflicts.

  • Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalized (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@gusandrioli
Copy link
Contributor Author

@jesseduffield Updated and ready for review. This is part of clean up process of moving things to lazycore :).

@jesseduffield jesseduffield merged commit 8f3ccd0 into jesseduffield:master Oct 15, 2022
@jesseduffield
Copy link
Owner

great work @gusandrioli :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants