allow null in keybindings
#2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added a comment on your gocui PR @Ryooooooga . |
Ryooooooga
force-pushed
the
disable-keybindings
branch
from
da2a709 to
7d643e3
Compare
Ryooooooga
force-pushed
the
disable-keybindings
branch
from
7d643e3 to
299b07e
Compare
jesseduffield
requested changes
Oct 16, 2022
| @@ -435,6 +435,8 @@ gui: | |||
|
|
|||
| For all possible keybinding options, check [Custom_Keybindings.md](https://github.com/jesseduffield/lazygit/blob/master/docs/keybindings/Custom_Keybindings.md) | |||
|
|
|||
| You can disable certain key bindings by specifying `null`. | |||
There was a problem hiding this comment.
Can we add an example here to be more obvious i.e.:
keybinding:
universal:
edit: nullThere was a problem hiding this comment.
also should this be the null keyword or the string 'null'?
There was a problem hiding this comment.
added.
also should this be the null keyword or the string 'null'?
I don't think it is necessary to accept the string 'null' since null keyword is clear enough in intent.
Ryooooooga
force-pushed
the
disable-keybindings
branch
from
299b07e to
808b35d
Compare
|
Nice work @Ryooooooga ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves: #2159
ref: #2161
requires: jesseduffield/gocui#23
go run scripts/cheatsheet/main.go generate)docs/Config.md) have been updated if necessary