Allow OSCommand.Quote to be invoked within a custom command
#2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesseduffield
requested changes
Oct 1, 2022
Ryooooooga
force-pushed
the
feature/template-funcs
branch
from
b21c2ab to
e16f1ba
Compare
|
add simple test case using existing integration test. |
| @@ -37,7 +37,7 @@ var FormPrompts = NewIntegrationTest(NewIntegrationTestArgs{ | |||
| { | |||
| Name: "bar", | |||
| Description: "Bar", | |||
| Value: "BAR", | |||
| Value: `"BAR"`, | |||
There was a problem hiding this comment.
Why are we quoting this? Shouldn't we not have quotes in the value so that we can ensure that it's properly quoted by the quote function?
There was a problem hiding this comment.
This is testing to be escaped " itself. Without | Quote, only BAR is output even if value is `"BAR"`.
There was a problem hiding this comment.
Ah I see: we need the quotes in the value so that when call the quote function the quotes are escaped and end up in the diff. Okay that makes sense!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many situations where we will want to use
Quote.go run scripts/cheatsheet/main.go generate)docs/Config.md) have been updated if necessary