Skip to content

Conversation

jesseduffield
Copy link
Owner

@jesseduffield jesseduffield commented Aug 26, 2022

  • PR Description

I migrated some more integration tests while on the plane to the states. Here they are!

Some important notes:

  • integration tests now run in parallel. It's possible that this can cause flakiness, because all tests wait 100ms before pressing their first key to allow views to refresh, and if a goroutine is stopped and then resumed, the 100ms could elapse without the views having even started refreshing.
  • the virtual screen is 100x100 characters, which should be big enough for most things. The helper function that lets you move your cursor to a particular line depends on that line already being visible in the view, meaning flakiness occurs if the screen is too small and the item is outside the visible content.
  • there were some rebase-related test failures. I'm pretty sure this was caused by the fact that if you try to press 'd' on a commit and you're in rebase mode but the commit hasn't been refreshed to consider itself as being a rebasing commit, you get asked whether you want to delete the commit (implicitly starting a rebase session). Ideally we should just have a way of asserting that we're done refreshing anything, but that'll take more work.
  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@jesseduffield jesseduffield force-pushed the more-integration-tests branch 2 times, most recently from 4aece0d to 076b514 Compare September 10, 2022 05:18
@jesseduffield jesseduffield merged commit ee34875 into master Sep 17, 2022
@jesseduffield jesseduffield deleted the more-integration-tests branch September 17, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant