-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI snapcraft installation #96
Conversation
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
=======================================
Coverage 23.61% 23.61%
=======================================
Files 13 13
Lines 1080 1080
=======================================
Hits 255 255
Misses 813 813
Partials 12 12 Continue to review full report at Codecov.
|
Should work, tested it in Docker on image that is used by CI. # testing procedure in Docker container based on circleci/golang:1.12 image
# while being in lazydocker source code dir
./.circleci/install_snapcraft.sh
curl -sL https://git.io/goreleaser | bash -s -- --skip-publish --snapshot --rm-dist --skip-sign Installation is a bit hacky from different sources, but the only official method of installing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and it works :)
I would like this to be baked into its own image but as you said this will only happen on release which will be infrequent so it should be fine.
Merge away :)
Hmm. We can always make our own image and push it to Docker Hub with everything needed already in it. Or try to contribute to goreleaser directly by adding snapcraft to their Dockerfile. But for now this solution may be enough. |
No description provided.