Fix Docker API version negotiation when DOCKER_API_VERSION is set #727
+10
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
DOCKER_API_VERSIONis set in the environment (e.g., to1.25), lazydocker fails with "client version 1.25 is too old" even though API version negotiation is enabled.Root Cause
client.FromEnvincludesWithVersionFromEnv(), which setsmanualOverride=truewhenDOCKER_API_VERSIONis present. This disables negotiation even whenWithAPIVersionNegotiation()is specified.Changes
pkg/commands/docker.go
client.FromEnvwith explicit options:WithTLSClientConfigFromEnv(),WithAPIVersionNegotiation(),WithHost()WithVersionFromEnv()to prevent manual override from blocking negotiationThis ensures the client always negotiates the API version with the daemon, providing backwards compatibility regardless of environment variable settings.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.