Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rTorrent): prevent extra commas in serialized XML #830

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

kannibalox
Copy link
Contributor

Description

I just happened to notice this while taking tcpdumps between flood and rTorrent, it doesn't appear to have an negative impact (both xmlrpc-c and tinyxml2 just ignore it), but I tracked it down out of curiosity.

Commands for testing:

console.log(value(["foo", "bar"]));
console.log(sParams(["foo", "bar"]));

Before:

<value><array><data><value><string>foo</string></value>,<value><string>bar</string></value></data></array></value>
<params><param><value><string>foo</string></value></param>,<param><value><string>bar</string></value></param></params>

After:

<value><array><data><value><string>foo</string></value><value><string>bar</string></value></data></array></value>
<params><param><value><string>foo</string></value></param><param><value><string>bar</string></value></param></params>

Related Issue

N/A

Screenshots

N/A

Types of changes

  • Breaking change (changes that break backward compatibility of public API or CLI - semver MAJOR)
  • New feature (non-breaking change which adds functionality - semver MINOR)
  • Bug fix (non-breaking change which fixes an issue - semver PATCH)

@trim21 trim21 merged commit 433ec24 into jesec:master Dec 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants