fix(client): react render logic

[hmerritt]

fix(client): react render logic

A couple react related fixes. One fixes a console error, the other an unwanted rendered result.

Description

• Fix: key={} must be set on the rendered component (cannot be passed down and set within the component)
• Fix: conditional rendering via && must be a conditional statement (not relying on value truthy/falsy) otherwise a 0 value will be rendered
  • Using != to fix instead of !== because it catches both null and undefined values

Related Issue

N/A

Screenshots

Before / After

Types of changes

• Breaking change (changes that break backward compatibility of public API or CLI - semver MAJOR)
• New feature (non-breaking change which adds functionality - semver MINOR)
• Bug fix (non-breaking change which fixes an issue - semver PATCH)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1781ecf) 72.27% compared to head (605fb79) 72.30%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #702      +/-   ##
==========================================
+ Coverage   72.27%   72.30%   +0.02%     
==========================================
  Files          62       62              
  Lines       11384    11384              
  Branches      938      937       -1     
==========================================
+ Hits         8228     8231       +3     
+ Misses       3142     3139       -3     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[trim21]

how can I re-produce first image (before)?

[hmerritt]

how can I re-produce first image (before)?

If you add a torrent with a magnet link, the file-size is unknown before the metadata is downloaded (which usually happens quite quickly) - I had a torrent with basically 0 seeders so it never downloaded the metadata - and the filesize logic in the UI rendered 0.