Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log into qBittorrent using HTTP-POST #594

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Conversation

Ian321
Copy link
Contributor

@Ian321 Ian321 commented Sep 9, 2022

Description

The API endpoint for login changed in qBittorrent (violating semver).

This patch has been tested with qBittorrent 4.4.0 - 4.4.5.

Related Issue

#592

Types of changes

  • Breaking change (changes that break backward compatibility of public API or CLI - semver MAJOR)
  • New feature (non-breaking change which adds functionality - semver MINOR)
  • Bug fix (non-breaking change which fixes an issue - semver PATCH)

@winterqt
Copy link
Contributor

winterqt commented Sep 9, 2022

This is compatible with previous qBittorrent versions, looking at the code. Should be actually tested before merging, though.

@Nedlinin
Copy link

Appears to fix the issue on my end; would love to see this merged and released.

@userdocs
Copy link

I hacked together a binary release using the patch from this pr via the existing release workflow to get the static binaries for testing

https://github.com/jesec/flood/pull/594.patch
https://github.com/userdocs/flood/commits/master

For people to test:

https://github.com/userdocs/flood/releases/tag/v4.7.1

Work fine in WSL2 in testing

release-4.4.5_v1.2.17 + v4.7.1
release-4.4.3.1_v1.2.17 v4.7.1

@userdocs
Copy link

4.3.9 worked as well in basic testing with an Ubuntu torrent. So I tested these as working with the PR so far.

release-4.3.9_v1.2.17
release-4.4.3.1_v1.2.17
release-4.4.5_v1.2.17

@winterqt
Copy link
Contributor

@jesec Any clue why grabbing the rTorrent binaries didn't work? Maybe try rerunning it?

@Nedlinin
Copy link

Nedlinin commented Sep 12, 2022

@jesec Any clue why grabbing the rTorrent binaries didn't work? Maybe try rerunning it?

"Error 404 – Not Found
GitHub produced an error for the download of artifact #253531637.

Usually this means that the artifact has expired (>90 days)."

Following the link manually also fails so a rerun won't work. Looks like the binary upload expired and needs to be renewed?

Edit: I may have misunderstood; you may have meant rerun the workflow on the rTorrent repo in which case, yes 👍 - I thought you meant rerun the failing workflows.

@winterqt
Copy link
Contributor

winterqt commented Sep 12, 2022

"Error 404 – Not Found GitHub produced an error for the download of artifact #253531637.

Usually this means that the artifact has expired (>90 days)."

Ah, didn't go to the link manually to see that message (I don't see it in the logs).

Following the link manually also fails so a rerun won't work.

(Did you see that message without going to the site?)

Looks like the binary upload expired and needs to be renewed?

Correct.

I thought you meant rerun the failing workflows.

I did mean that, since I didn't know the error was expected.

@Nedlinin
Copy link

(Did you see that message without going to the site?)

Nope, I manually went to the link that the workflow is attempting to download in order to see that message.

@jesec jesec merged commit aa962eb into jesec:master Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants