Failing APIs in the v4.12.x releases

[adyanth]

Type: Bug Report

• Try to follow the update procedure described in the README and try again before opening this issue.

Your Environment

• Version used: v4.12.5
• Environment name and version: docker image
• Operating system and version: N/A
• Torrent client and version: transmission 4.0.5

Summary

The UI settings save and torrent add from Sonarr both fail on v4.12.x released two days ago, but works fine on v4.11.0

Expected Behavior

Everything should still work on a minor version update

Current Behavior

Many APIs failing with a UI error on both Flood and Sonarr

Possible Solution

Steps to Reproduce

1. Update Flood
2. Try editing the settings for compact to expanded UI, enable reannounce and save
3. See a failure pop up
4. Try adding a Flood client in sonarr, see it fail to verify

Context

[trim21]

any details in logging of sonarr？

[adyanth]

Not much:

[v4.0.16.2944] NzbDrone.Core.Download.Clients.DownloadClientException: Unable to connect to Flood, please check your settings
   at NzbDrone.Core.Download.Clients.Flood.FloodProxy.HandleRequest(HttpRequest request, FloodSettings settings) in ./Sonarr.Core/Download/Clients/Flood/FloodProxy.cs:line 81
   at NzbDrone.Core.Download.Clients.Flood.FloodProxy.AddTorrentByFile(String file, IEnumerable`1 tags, FloodSettings settings) in ./Sonarr.Core/Download/Clients/Flood/FloodProxy.cs:line 140
   at NzbDrone.Core.Download.Clients.Flood.Flood.AddFromTorrentFile(RemoteEpisode remoteEpisode, String hash, String filename, Byte[] fileContent) in ./Sonarr.Core/Download/Clients/Flood/Flood.cs:line 94
   at NzbDrone.Core.Download.TorrentClientBase`1.DownloadFromWebUrl(RemoteEpisode remoteEpisode, IIndexer indexer, String torrentUrl) in ./Sonarr.Core/Download/TorrentClientBase.cs:line 215
   at NzbDrone.Core.Download.TorrentClientBase`1.Download(RemoteEpisode remoteEpisode, IIndexer indexer) in ./Sonarr.Core/Download/TorrentClientBase.cs:line 129
   at NzbDrone.Core.Download.DownloadService.DownloadReport(RemoteEpisode remoteEpisode, IDownloadClient downloadClient) in ./Sonarr.Core/Download/DownloadService.cs:line 143
   at NzbDrone.Core.Download.DownloadService.DownloadReport(RemoteEpisode remoteEpisode, Nullable`1 downloadClientId) in ./Sonarr.Core/Download/DownloadService.cs:line 64
   at NzbDrone.Core.Download.ProcessDownloadDecisions.ProcessDecisionInternal(DownloadDecision decision, Nullable`1 downloadClientId) in ./Sonarr.Core/Download/ProcessDownloadDecisions.cs:line 226

[trim21]

What's the error on flood UI? can you use browser's develop tools to find the HTTP response?

[adyanth]

It does not say much other than "An unknown error occurred".

Looking at the API, it is a PATCH to /api/settings that gets a 400 with the following response, which seems different in cause from the Sonarr being unable to test connection.

{
    "code": "FST_ERR_VALIDATION",
    "message": "body/UITagSelectorMode [\n  {\n    \"expected\": \"'single' | 'multi'\",\n    \"received\": \"null\",\n    \"code\": \"invalid_type\",\n    \"path\": [\n      \"UITagSelectorMode\"\n    ],\n    \"message\": \"Expected 'single' | 'multi', received null\"\n  }\n]"
}

[trim21]

do you set a baseuri on flood side?

[adyanth]

No, just running it with

flood --host "0.0.0.0" --port "3000" --auth none \
              --trurl http://transmission:9091/transmission/rpc \
              --truser user --trpass pass

[trim21]

I'll take a deeper look after work

[mirolm]

I noticed that with the latest master settings do not load - you can change settings, resize torrent list columns and after a browser reload everything is back to defaults. Chrome dev tools shows error 500 while trying to access /api/settings.

[trim21]

emmmm, I can't re-produce any of these on current master 3b13b40

[trim21]

[mirolm]

Here is screenshot (flood 4.12.5) from settings:

[trim21]

would you mind also paste request and response here?

[mirolm]

[trim21]

@mirolm please try master branch