fix scan timeframe with use_terms_query #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following issue Yelp/elastalert#3041 and PR Yelp/elastalert#3141, when a rule has
[scan_entire_timeframe: true] and [use_terms_query: true or use_count_query: true], the timeframe (i.e. 5 days) is evaluated correctly just at first run; from the second one, the timeframe will be set accordly torun_everyvalue (i.e. 5 minutes).This change only affects rules with option use_count_query or use_term_query.
Checklist
make test-dockerwith my changes.Questions or Comments