Merge pull request #1594 from thican/dev/fix_data_reading

Fix returned type around datetime
jertel · Dec 23, 2024 · 858f9cc · 858f9cc
2 parents b1680e6 + 1e0a770
commit 858f9cc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@
 
 ## Other changes
 - [Docs] Add missing documentation of the `aggregation_alert_time_compared_with_timestamp_field` option. - [#1588](https://github.com/jertel/elastalert2/pull/1588) - @nicolasnovelli
+- Fix linter error reporting about return type assignation in `elastalert/test_rule.py`. - [#1594](https://github.com/jertel/elastalert2/pull/1594) - @thican
 
 # 2.22.0
 

diff --git a/elastalert/test_rule.py b/elastalert/test_rule.py
@@ -137,7 +137,7 @@ def _parse_args(self, args: list) -> argparse.Namespace:
 
         return parsed_args
 
-    def str_to_ts(self, input: str) -> datetime:
+    def str_to_ts(self, input: str) -> datetime.datetime:
         if input == "NOW":
             return self.ts_now
 
@@ -148,7 +148,7 @@ def str_to_ts(self, input: str) -> datetime:
                 f"Input is not a valid ISO8601 timestamp (YYYY-MM-DDTHH:MM:SS+XX:00): {input}"
             )
 
-    def parse_starttime(self, timeframe=None) -> datetime:
+    def parse_starttime(self, timeframe=None) -> datetime.datetime:
         if self.args.start:
             try:
                 return self.str_to_ts(self.args.start)