Skip to content

Fix syscall assertion when input file does not exist #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dbatyai
Copy link
Member

@dbatyai dbatyai commented Apr 11, 2016

Errors should be handled by caller instead of exiting.

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai@inf.u-szeged.hu

@akosthekiss
Copy link
Member

It seems that you've removed LIBC_EXIT_ON_ERROR from the linux port only. I feel that we should keep the darwin port in sync as well.
Moreover, once the suggested changes are applied, will there be any use of LIBC_EXIT_ON_ERROR? (If not, that can go away too.)

@dbatyai dbatyai force-pushed the nonexistent_input_syscall_assert branch from 663555e to dfd751d Compare April 11, 2016 10:48
@dbatyai
Copy link
Member Author

dbatyai commented Apr 11, 2016

I've updated the darwin port, and removed LIBC_EXIT_ON_ERROR entirely.

@zherczeg
Copy link
Member

LGTM

@akosthekiss
Copy link
Member

LGTM (FWIW)

@akosthekiss
Copy link
Member

(Please, update to current master.)

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai@inf.u-szeged.hu
@dbatyai dbatyai force-pushed the nonexistent_input_syscall_assert branch from dfd751d to 764229b Compare April 11, 2016 12:34
@akosthekiss akosthekiss merged commit 764229b into jerryscript-project:master Apr 11, 2016
@dbatyai dbatyai deleted the nonexistent_input_syscall_assert branch April 19, 2016 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants