Skip to content

Add jerry_port_abort API #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

franc0is
Copy link
Contributor

Calling abort() is making assumptions about what the target wants to happen on fatal errors. In fact, I would argue the stdlib definition of abort doesn't make much sense on some platforms.

JerryScript-DCO-1.0-Signed-off-by: François Baldassari francois@pebble.com

@franc0is franc0is changed the title Add jerry_port_abort API Add jerry_port_abort API Mar 10, 2016
JerryScript-DCO-1.0-Signed-off-by: François Baldassari francois@pebble.com
@seanshpark
Copy link
Contributor

@franc0is , I had similar problem with abort().
what do you think about moving system related codes like this code.

+void jerry_port_abort (void)
 +{
 +  abort ();
 +} /* jerry_port_abort */

outside of jerry and let users implement them as the system works?

@franc0is
Copy link
Contributor Author

In one of my other PRs, I moved the jerry-port code to the "target"
directory so it can be implemented by the port.

Additionally, you can always provide those symbols elsewhere in your system
once my PR lands (hopefully!) and the default port code is no longer
included for every build.

Does that work for you?

On Thursday, March 17, 2016, SaeHie Park notifications@github.com wrote:

@franc0is https://github.com/franc0is , I had similar problem with
abort().
what do you think about moving system related codes like this code.

+void jerry_port_abort (void)
+{

  • abort ();
    +} /* jerry_port_abort */

outside of jerry and let users implement them as the system works?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#957 (comment)

@seanshpark
Copy link
Contributor

@franc0is , sounds nice :)

@LaszloLango LaszloLango added the jerry-port Related to the port API or the default port implementation label Mar 18, 2016
@franc0is
Copy link
Contributor Author

Superseded by #1015

@franc0is franc0is closed this Apr 21, 2016
@franc0is franc0is deleted the port-abort branch April 21, 2016 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jerry-port Related to the port API or the default port implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants