Few improvements for RegExp #947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaszloLango
added
enhancement
| if (cache_idx < RE_CACHE_SIZE) | ||
| if (cache_idx >= RE_CACHE_SIZE) | ||
| { | ||
| if (re_cache_idx < 1u) |
There was a problem hiding this comment.
Actually, in these two ifs, we are checking whether cache_idx == RE_CACHE_SIZE and re_cache_idx == 0, aren't we? (I mean, there is no way for cache_idx to be striclty larger that RE_CACHE_SIZE, and re_cache_idx being unsigned, it cannot have negative value.) I'd vote for the exact equality tests.
LaszloLango
force-pushed
the
improve-regexp-cache
branch
from
7891675 to
90db124
Compare
LaszloLango
force-pushed
the
improve-regexp-cache
branch
from
90db124 to
f58c816
Compare
| */ | ||
| const re_compiled_code_t * | ||
| static uint16_t |
There was a problem hiding this comment.
I see now that re_cache_idx is uint16_t. If we want to force a small number we could use uint8_t. Anyway I am even happy with uint32_t as well.
Otherwise LGTM.
LaszloLango
force-pushed
the
improve-regexp-cache
branch
from
f58c816 to
74cdc68
Compare
|
@zherczeg, updated. May I land this? |
LaszloLango
force-pushed
the
improve-regexp-cache
branch
from
74cdc68 to
ba4e52d
Compare
|
LGTM |
Added eviction mechanism to RegExp cache and small refactoring. Fixed a bug when logging is enabled. Related issue: jerryscript-project#927 JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
LaszloLango
force-pushed
the
improve-regexp-cache
branch
from
ba4e52d to
6f536c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added eviction mechanism to RegExp cache and small
refactoring. Fixed a bug when logging is enabled.
Related issue: #927
JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com