Add acquire_value API to simplify caller code #944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -635,6 +635,24 @@ jerry_api_release_object (jerry_api_object_t *object_p) /**< pointer acquired th | |||
| } /* jerry_api_release_object */ | |||
|
|
|||
| /** | |||
| * Acquire specified Jerry API value | |||
| */ | |||
There was a problem hiding this comment.
Missing @return ... comment
|
Besides that missing comment the patch looks good. |
LaszloLango
added
api
|
|
||
| if (value_p->type == JERRY_API_DATA_TYPE_STRING) | ||
| { | ||
| jerry_api_acquire_string (value_p->u.v_string); |
There was a problem hiding this comment.
missing return statement
There was a problem hiding this comment.
Duh. Sorry for the silly mistake. Added the return statement at the bottom of the function.
|
|
franc0is
force-pushed
the
acquire-value
branch
2 times, most recently
from
0a1f1b2 to
b80b860
Compare
|
@franc0is, thank you for the updates. LGTM |
|
LGTM. I would like to (probably will) rename these acquire / release stuff to ref / deref (just a heads up). |
|
(Once rebased, we can/will land it.) |
JerryScript-DCO-1.0-Signed-off-by: François Baldassari francois@pebble.com
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: François Baldassari francois@pebble.com