Don't use messages for errors by default #941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
File size of
Result of after: |
| #ifndef JERRY_NDEBUG | ||
| #define ERROR_MSG(msg) msg | ||
| #else /* JERRY_NDEBUG */ | ||
| #define ERROR_MSG(msg) NULL |
There was a problem hiding this comment.
I'd suggest prefixing this macro, e.g., with ECMA_.
LaszloLango
force-pushed
the
add-error-msg-macro
branch
from
58e5cba to
3053e02
Compare
LaszloLango
changed the title
|
@zherczeg, @akiss77 the patch is updated. I introduced a new build option ( |
|
LGTM (FWIW) |
|
LGTM |
Use empty string for message property of builtin error objects by default. Add ERROR_MESSAGES build option. JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
LaszloLango
force-pushed
the
add-error-msg-macro
branch
from
3053e02 to
ab26d57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #897
JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com