Skip to content

Add ARM cross build and QEMU user space emulated tests to the CI #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2016

Conversation

akosthekiss
Copy link
Member

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu

@akosthekiss akosthekiss added feature request Requested feature infrastructure Related to GH Actions or the tested targets labels Feb 17, 2016
@akosthekiss
Copy link
Member Author

Travis CI has no ARM devices to deploy and test the project on, but we could have QEMU user space emulation running. This way cross building for ARM and emulated execution of ARM code could be tested for every PR and push. Builds are of the same speed, tests are somewhat slower (but still not that bad). Opinions?

@zherczeg
Copy link
Member

Can you install something on Travis?

@akosthekiss
Copy link
Member Author

Please, do have a look at the .travis.yml file... (And tools/apt-get-install-*.sh.) They are among the changed files of this very PR. That's how dependences are already installed (e.g., gcc-arm-none-eabi, cppcheck, vera++, etc.).

The question is not whether we can do it (yes, we can) but whether we want it?

@LaszloLango
Copy link
Contributor

I'd like this feature. +1

@zherczeg
Copy link
Member

If it does not slow down the CI too much, it is ok for me.

@zherczeg
Copy link
Member

Akos, do you plan to land this patch?

@akosthekiss
Copy link
Member Author

@zherczeg I'd like to, but on current master, we have 5 failures on arm/linux. This would turn all PRs and even the master red, so I'd keep this PR open until the failures are fixed. I'll open an issue for the problem.

@LaszloLango
Copy link
Contributor

@akiss77, @zherczeg please check #929

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
@akosthekiss
Copy link
Member Author

The patch has been rebased. All blocker issues have been solved, so I think we are ready to re-introduce arm builds and emulate arm tests.
@LaszloLango @zherczeg r?

@LaszloLango
Copy link
Contributor

LGTM

1 similar comment
@zherczeg
Copy link
Member

zherczeg commented Mar 9, 2016

LGTM

@akosthekiss akosthekiss merged commit 81d4c97 into jerryscript-project:master Mar 9, 2016
@akosthekiss akosthekiss deleted the qemu-arm-ci branch March 9, 2016 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requested feature infrastructure Related to GH Actions or the tested targets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants