Eliminate cpp featureset #876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # Imported libraries | ||
| if(("${PLATFORM}" STREQUAL "DARWIN") AND (NOT (CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX))) | ||
| if(("${PLATFORM}" STREQUAL "DARWIN") AND (NOT (CMAKE_COMPILER_IS_GNUCC))) |
There was a problem hiding this comment.
Unnecessary parentheses around CMAKE_COMPILER_IS_GNUCC
|
Please, also update docs/DEVELOPMENT.md |
|
Please provide some statistics about code size and performance. |
LaszloLango
added
enhancement
|
(The |
| @@ -1,4 +1,4 @@ | |||
| /* Copyright 2015 Samsung Electronics Co., Ltd. | |||
| /* Copyright 2015 Samsung Electronics Co., Ltd. | |||
There was a problem hiding this comment.
accident change, remove space
robertsipka
force-pushed
the
eliminate_cpp
branch
from
d7c2c8d to
5c25075
Compare
|
Thanks for the comments, I've updated the patch and rebased with master. |
| @@ -3,7 +3,7 @@ | |||
| Currently, only Ubuntu 14.04+ is officially supported as primary development environment. | |||
|
|
|||
| There are several dependencies, that should be installed manually. The following list is required for building: | |||
| - `gcc` or `g++` higher than `4.8.2` | |||
| - `gcc` higher than `4.8.2` | |||
There was a problem hiding this comment.
Do we need gcc 4.8.2 for a C99 compatible engine?
|
Nice job! LGTM. I think we could reduce the minimum GCC version, but that is not important at the moment. |
robertsipka
force-pushed
the
eliminate_cpp
branch
2 times, most recently
from
0c76bfe to
c9a0241
Compare
Use c-style cast instead of reinterpret_cast. Use identifiers for function parameters. Use type cast to avoid conversion error. JerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com
Move all '.cpp' files to '.c'. Rename comments from 'cpp' to 'c'. JerryScript-DCO-1.0-Signed-off-by: Roland Takacs rtakacs.u-szeged@partner.samsung.com JerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com
robertsipka
force-pushed
the
eliminate_cpp
branch
from
c9a0241 to
977bfa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.