Refactoring the build system #867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosthekiss
added
enhancement
|
WIP patch, still conflicts with some recently landed patches. All thoughts and feedbacks are most welcome. |
|
Side note: with ninja, a full precommit run became somewhat faster (3m53s -> 3m22s). |
|
#868 is merged into master. |
akosthekiss
force-pushed
the
make-refactor
branch
from
e699c74 to
0ade53d
Compare
|
Rebased to master, but still WIP. |
|
This may be related: #664 |
akosthekiss
force-pushed
the
make-refactor
branch
2 times, most recently
from
f7183c3 to
91b3ad0
Compare
|
Improved & rebased & pushed. It starts looking OK to me so reviews/feedbacks can start rolling. |
|
Please rename |
|
Renamed. |
|
@akiss77, thanks. LGTM |
akosthekiss
force-pushed
the
make-refactor
branch
from
ffa5b3a to
3d270f1
Compare
* Removed unused or unnecessary parts from various make files
* Eliminated lots of duplications from Makefile with the help of
macros.
* Split tools/precommit.sh to its independent components:
* the part that checks the existence of the "signed off" text in
commit messages
(this on got factored out to tools/check-signed-off.sh),
* the part that uses vera++ for style checking (this one got
factored out to tools/check-vera.sh),
* the part that invokes targets in the cmake-generated build
directory, and
* the part that performs various tests (these latter two got
moved into the Makefile).
* Moved the functionality of precommit-full-testing.sh into the
Makefile, too.
* Added ninja build system support (e.g., `make NINJA=1`).
* Updated leading documentation comments (they were somewhat
stale).
* Tried to keep the target names exactly the same as they were --
almost succeeded... (some changes are intentional, and are
subject to personal preferences).
* Simplified console output of `make precommit`
* Unified test runner scripts and their output format
* Eliminated nothing-to-stdout everything-to-log-file policy:
info is printed to stdout and it is the caller's
responsibility to redirect it to a file if needed.
* Also applied some renaming and coding style unification to
the scripts.
* Merged the functionality of tools/runners/run-test-suite-jerry*.sh
into the Makefile
* Merged everything related to a test suite execution in a single
script.
* The new script also allows to specify pass and xfail tests in
a single list file, which was not possible hitherto.
* Also, the paths of the test cases given in a file are
interpreted relative to their container files.
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
akosthekiss
force-pushed
the
make-refactor
branch
from
3d270f1 to
f959ba9
Compare
|
Merged f959ba9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macros.
commit messages
(this on got factored out to tools/check-signed-off.sh),
factored out to tools/check-vera.sh),
directory, and
moved into the Makefile).
make NINJA=1).stale).
almost succeeded... (some changes are intentional, and are
subject to personal preferences).
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu