Skip to content

Fix the correct number of command line arguments check. #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

robertsipka
Copy link
Contributor

No description provided.

JerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com
@akosthekiss akosthekiss added the bug Undesired behaviour label Feb 4, 2016
@sand1k
Copy link
Contributor

sand1k commented Feb 5, 2016

I think we need to add a test for this.

@robertsipka
Copy link
Contributor Author

Do you have any suggestions where I could do this kind of test? It might be part of the unit tests or what do you mean exactly?

@LaszloLango
Copy link
Contributor

Do we really need this limit? I prefer to remove this condition.

@akosthekiss
Copy link
Member

@LaszloLango The fixed-length arrays file_names and exec_snapshot_file_names rely on JERRY_MAX_COMMAND_LINE_ARGS. Actually, these arrays are the reason for the existence of this macro. Since we cannot rely on dynamic memory allocation, there has to be a fixed limit, for now at least.

@LaszloLango
Copy link
Contributor

@akiss77, I see. Thanks for the explanation. The patch looks good to me.

@LaszloLango
Copy link
Contributor

Landed (2221c00)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants