Move jerry_port functions into jerry-core #824
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Please update this patch to the latest jerry. |
rtakacs
force-pushed
the
jerry-port-funcs
branch
2 times, most recently
from
c29c3fa to
162b13a
Compare
|
Done. |
| @@ -13,8 +13,8 @@ | |||
| * limitations under the License. | |||
There was a problem hiding this comment.
Copyright years need to be updated.
rtakacs
force-pushed
the
jerry-port-funcs
branch
from
162b13a to
d412eb5
Compare
JerryScript-DCO-1.0-Signed-off-by: Roland Takacs rtakacs.u-szeged@partner.samsung.com
rtakacs
force-pushed
the
jerry-port-funcs
branch
from
d412eb5 to
c7156dd
Compare
|
I have rebased the patch to the master. |
|
@rtakacs, thanks. Still looks good to me. |
|
Landed (6608cc4) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid linking errors when building Jerry as a library (eg. for IoT.js).