Refactor literal-storage to not use C++ features

[rtakacs]

This patch removes all C++ features from the literal-storage. The functionality is the same, just the code structure is different.

Measurement results:

testing board:  rpi2
master revision: 4f44071

section	master size	with patch
.note.gnu.build-id	36	36
.text	190012	189612
.rodata	8176	8124
.ARM.exidx	8	8
.init_array	4	4
.data	1096	1096
.bss	2363840	2363848
.comment	40	40
.ARM.attributes	47	17
Total	2563259	2562815

[zherczeg]

Nice job!

[seanshpark]

+1

[sand1k]

I've rebased this patch onto the latest master. Please, check https://github.com/Samsung/jerryscript/tree/refactor-lit-storage-rebased

[rtakacs]

Thank you Andrey! I've updated this PR.

[rtakacs]

Measurement results:

testing board:  rpi2
master revision: 50d124b

section	size (master)	size (patch)
.note.gnu.build-id	36	36
.text	191100	191052
.rodata	8344	8332
.ARM.exidx	8	8
.init_array	4	4
.data	1096	1096
.bss	2363776	2363784
.comment	40	40
.ARM.attributes	47	47
Total	2564451	2564399

Benchmark	RSS (+ is better)	Perf (+ is better)
3d-cube.js	112-> 112 (0.000)	2.979-> 2.98 (-0.034)
access-binary-trees.js	84-> 84 (0.000)	1.835-> 1.833 (0.109)
access-fannkuch.js	40-> 40 (0.000)	8.816-> 8.98 (-1.860)
access-nbody.js	48-> 48 (0.000)	4.15-> 4.206 (-1.349)
bitops-3bit-bits-in-byte.js	32-> 32 (0.000)	2.255-> 2.261 (-0.266)
bitops-bits-in-byte.js	32-> 32 (0.000)	3.041-> 3.019 (0.723)
bitops-bitwise-and.js	32-> 32 (0.000)	3.415-> 3.411 (0.117)
controlflow-recursive.js	220-> 220 (0.000)	1.545-> 1.555 (-0.647)
crypto-aes.js	124-> 124 (0.000)	5.478-> 5.33 (2.702)
crypto-md5.js	184-> 184 (0.000)	33.818->32.642 (3.477)
crypto-sha1.js	132-> 132 (0.000)	14.971->14.542 (2.865)
date-format-xparb.js	72-> 72 (0.000)	1.656-> 1.655 (0.060)
math-cordic.js	40-> 40 (0.000)	3.29-> 3.305 (-0.456)
math-partial-sums.js	32-> 32 (0.000)	1.909-> 1.889 (1.048)
math-spectral-norm.js	40-> 40 (0.000)	2.057-> 2.047 (0.486)
string-fasta.js	48-> 48 (0.000)	5.662-> 5.588 (1.307)
Geometric mean:	RSS reduction: 0%	Speed up: 0.528%

[galpeter]

Two things:

1. str -> str_p
2. imho 'placed in the record' -> 'placed into the record'

[ruben-ayrapetyan]

Usually, we put comments after #endif to describe condition, corresponding to code just above the #endif. For example, !RCS_RECORDS_H in the case.

[ruben-ayrapetyan]

Looks good to me

[sand1k]

lit_create_magic_literal_ex

[galpeter]

Shouldn't this be !RCS_SNAPSHOT_H ?

[rtakacs]

Yes it should, I missed that.

[galpeter]

This should be: rcs_record_set_magic_str_ex_id

[galpeter]

lgtm

[galpeter]

merged: 21f561f

[jiangzidong]

@galpeter @sand1k and @ruben-ayrapetyan
Is Jerry going to remove all c++ features and become a pure C project?

[tilmannOSG]

@jiangzidong Yes, that's correct. Several months ago a decision was made to move back to C and we are now incrementally rewriting the remaining C++ parts of JerryScript in C.

[jiangzidong]

@tilmannOSG Thanks. Do you have a schedule about when to complete the refactor

[tilmannOSG]

@jiangzidong We don't have a strict schedule but we aim to complete the move to C in the coming months.

[jiangzidong]

@tilmannOSG I see, and I am working on removing c++ features of the rcs_chunked_list

[tilmannOSG]

@jiangzidong That's great :) Contributions in that area are very welcome!