Removing magic number from mem_block_header_t #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan r.ayrapetyan@samsung.com
ruben-ayrapetyan
force-pushed
the
Ruben-remove-magic_num-from-heap-block-header
branch
from
f2156ef to
593b1d7
Compare
ruben-ayrapetyan
added
normal
memory management
ruben-ayrapetyan
deleted the
Ruben-remove-magic_num-from-heap-block-header
branch
Contributor
There was a problem hiding this comment.
Shouldn't this be marked as always inline?
Author
There was a problem hiding this comment.
I suppose that this small function would be always inlined by compiler automatically.
If not, we would add the always_inline during optimization stage.
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.