Implement AnnexB RegExp.prototype.compile() #579
Conversation
dbatyai
added
ecma builtins
dbatyai
force-pushed
the
regexp-compile
branch
from
cf0788c to
c1f72df
Compare
There was a problem hiding this comment.
Do we need variable arguments here? Can't we simply have two arguments?
|
Quite a good patch, just a few things |
dbatyai
force-pushed
the
regexp-compile
branch
from
c1f72df to
6b02c71
Compare
|
@zherczeg, @ruben-ayrapetyan I've updated the patch based on your comments. |
There was a problem hiding this comment.
ecma_is_completion_value_empty? In the case, completion value doesn't need to be freed.
|
After fixing #579 (comment) and #579 (comment) the changes would look good to me. |
dbatyai
force-pushed
the
regexp-compile
branch
from
6b02c71 to
b74e9cd
Compare
There was a problem hiding this comment.
Just one question: can we rewrite non-configurable properties? E.g. re2.compile(re1); what is happening, if re2.global is non configurable? It would worth adding a test to show that it works.
There was a problem hiding this comment.
We can, because we use the internal API to do it. Also, all flag properties are already non-configurable, so the currently added test cases should cover testing this.
|
LGTM in general, but please check whether we can overwrite non-configurable properties. |
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com
dbatyai
force-pushed
the
regexp-compile
branch
from
b74e9cd to
13941df
Compare
3 participants
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com