Implement String.prototype.split function #530
Conversation
bzsolt
force-pushed
the
string-prototype-split
branch
from
b27c817 to
704f1df
Compare
LaszloLango
added
ecma builtins
| ecma_string_t *magic_str_p = ecma_get_magic_string (LIT_MAGIC_STRING_INDEX); | ||
| ecma_property_t *index_prop_p = ecma_find_named_property (obj_p, magic_str_p); | ||
|
|
||
| JERRY_ASSERT (index_prop_p != NULL); |
There was a problem hiding this comment.
ecma_get_named_property could be used in the case. The version includes assertion from line 1715.
bzsolt
force-pushed
the
string-prototype-split
branch
from
704f1df to
976500d
Compare
|
I've fixed the mentoined parts. |
|
@bzsolt, thank you! I've got no other comments. |
| { | ||
| assert (e instanceof ReferenceError); | ||
| assert (e.message === "foo"); | ||
| } |
There was a problem hiding this comment.
I dont see a similar test from the spec:
"A<B>bold</B>and<CODE>coded</CODE>".split(/<(\/)?([^<>]+)>/) ->
["A", undefined, "B", "bold", "/", "B", "and", undefined, "CODE", "coded", "/", "CODE", ""]
There was a problem hiding this comment.
You are right. I've implemented the missing part and added a related testcase (what you wrote).
Thanks.
|
LGTM. |
bzsolt
force-pushed
the
string-prototype-split
branch
from
976500d to
5277461
Compare
|
@ruben-ayrapetyan @sand1k |
| ecma_string_t *idx_str_p = ecma_new_ecma_string_from_uint32 (i); | ||
| ecma_string_t *new_array_idx_str_p = ecma_new_ecma_string_from_uint32 (new_array_length); | ||
|
|
||
| ecma_completion_value_t match_comp_value = ecma_op_object_get (match_array_obj_p, idx_str_p); |
There was a problem hiding this comment.
Couldn't this operation throw an exception?
There was a problem hiding this comment.
This should never throw an exception. I've added an extra assert to make sure.
JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély zsborbely.u-szeged@partner.samsung.com
bzsolt
force-pushed
the
string-prototype-split
branch
from
5277461 to
640370d
Compare
|
I've got no other comments. |
|
lgtm |
JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély zsborbely.u-szeged@partner.samsung.com