Fix regexp match on right brackets #512
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaszloLango
added
bug
| ret_value = ecma_raise_range_error ("RegExp executor steps limit is exceeded."); | ||
| return ret_value; | ||
| } | ||
| re_ctx_p->match_limit++; |
There was a problem hiding this comment.
I think the match limit counter should be removed from the executor context as well, since we don't use it anymore.
There was a problem hiding this comment.
@dbatyai, fixed.
LaszloLango
force-pushed
the
fix_regexp_match_on_right_brackets
branch
from
443011d to
fc50238
Compare
|
Good to me |
JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
LaszloLango
force-pushed
the
fix_regexp_match_on_right_brackets
branch
from
fc50238 to
a9121d2
Compare
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #257
Related test262 tests:
ch15/15.10/15.10.2/S15.10.2_A1_T1ch15/15.10/15.10.2/15.10.2.6/S15.10.2.6_A4_T7