Skip to content

Ensure command line prompt is displayed #5033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2023
Merged

Ensure command line prompt is displayed #5033

merged 1 commit into from
Jan 9, 2023

Conversation

rtakacs
Copy link
Contributor

@rtakacs rtakacs commented Jan 3, 2023

As #5030 pointed out, js > prompt hasn't been shown in the terminal. This patch solves that by flushing stdout manually.

@rtakacs rtakacs mentioned this pull request Jan 3, 2023
Closed
@rtakacs
Copy link
Contributor Author

rtakacs commented Jan 3, 2023

Note: failing jobs are fixed by #5032

ossy-szeged
ossy-szeged approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@ossy-szeged ossy-szeged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

robertsipka
robertsipka approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@robertsipka robertsipka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtakacs rtakacs changed the title Flush the output buffer in jerry_port_print_buffer Ensure command prompt to be appeared when REPL is used Jan 4, 2023
@rtakacs rtakacs changed the title Ensure command prompt to be appeared when REPL is used Ensure command line prompt is displayed Jan 4, 2023
@rtakacs
Ensure command prompt is displayed when REPL is used
c0fceb6 
JerryScript-DCO-1.0-Signed-off-by: Roland Takacs rtakacs@inf.u-szeged.hu
@ossy-szeged ossy-szeged merged commit 1a2c047 into jerryscript-project:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ossy-szeged ossy-szeged ossy-szeged approved these changes

@robertsipka robertsipka robertsipka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rtakacs @ossy-szeged @robertsipka