Skip to content

Fix arguments object detection in non-complex param list #4867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rerobika
Copy link
Member

@rerobika rerobika commented Dec 8, 2021

This patch is the followup of #4849.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik robert.fancsik@h-lab.eu

@rerobika rerobika added the pre-scanner Related to the JavaScript pre-scanner label Dec 8, 2021
Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is better.

This patch is the followup of jerryscript-project#4849.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik robert.fancsik@h-lab.eu
@rerobika rerobika force-pushed the fix_arguments_object_creation branch from eb05324 to dae6590 Compare December 8, 2021 10:25
@rerobika rerobika requested a review from zherczeg December 8, 2021 10:37
Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ossy-szeged ossy-szeged merged commit ce5c849 into jerryscript-project:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-scanner Related to the JavaScript pre-scanner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants