Split main promise event filter into multiple filters #4792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
zherczeg
force-pushed
the
promise_filters
branch
from
1cc216d to
5a1db9a
Compare
galpeter
reviewed
Oct 11, 2021
| * JERRY_PROMISE_EVENT_RESOLVE | ||
| * JERRY_PROMISE_EVENT_REJECT */ | ||
| JERRY_PROMISE_EVENT_FILTER_ERROR = (1 << 1), /**< enables the following events: | ||
| JERRY_PROMISE_EVENT_FILTER_CREATE = (1 << 0), /**< enables the following event: |
There was a problem hiding this comment.
Would it make sense to keep the JERRY_PROMISE_EVENT_FILTER_MAIN and specify it's value as: JERRY_PROMISE_EVENT_FILTER_CREATE | JERRY_PROMISE_EVENT_FILTER_RESOLVE | JERRY_PROMISE_EVENT_FILTER_REJECT ? That way we keep the old way (which will catch the "main" cases) and will have the new more fine tuned option.
There was a problem hiding this comment.
This has never been released, so there is no need to worry about compatiblity.
Comment on lines
+137
to
+139
| jerry_promise_event_filter_t filters = (JERRY_PROMISE_EVENT_FILTER_CREATE | ||
| | JERRY_PROMISE_EVENT_FILTER_RESOLVE | ||
| | JERRY_PROMISE_EVENT_FILTER_REJECT |
There was a problem hiding this comment.
Missing tests where only one of these are captured.
There was a problem hiding this comment.
I know, but there are currently no tests for splitting filters. We plan to add more tests in the future.
rerobika
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.