Implement String.prototype.indexOf() #456
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const ecma_length_t search_len = ecma_string_get_length (search_str_p); | ||
| const lit_utf8_size_t search_size = ecma_string_get_size (search_str_p); | ||
|
|
||
| ecma_number_t * ret_num = ecma_alloc_number (); |
There was a problem hiding this comment.
No need for space after the *
dbatyai
added
ecma builtins
JerryScript-DCO-1.0-Signed-off-by: Laszlo Vidacs lvidacs.u-szeged@partner.samsung.com
lvidacs
force-pushed
the
string-prototype-indexof
branch
from
e8089ce to
6f20a12
Compare
|
@galpeter, thanks for the review, the code is updated also with the _p suffix. |
|
Good to me |
|
lgtm |
|
Landed: 64c81cc |
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Laszlo Vidacs lvidacs.u-szeged@partner.samsung.com