Added rules for coding style checking. #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,45 @@ | |||
| #!/usr/bin/tclsh | |||
|
|
|||
| # Copyright 2014-2015 Samsung Electronics Co., Ltd. | |||
There was a problem hiding this comment.
"Copyright 2015" as it is new file, created in the current year, isn't it correct?
|
Andrey, update copyright for all newly created files. Fix the issues and merge it into mainline. |
|
@egavrin, @ruben-ayrapetyan, copyright and commit message were updated, please check. |
|
@sand1k LGTM |
| } | ||
| } | ||
|
|
||
| if {$tok_type in {if for do else } || ($tok_type == "while" && $prev_tok != "rightbrace")} { |
There was a problem hiding this comment.
The following case of style breaking is not catched:
while (p)
{
p = false;
}
while (q)
q = false;
|
@ruben-ayrapetyan, issues that you mentioned were fixed. |
JerryScript-DCO-1.0-Signed-off-by: Andrey Shitov a.shitov@samsung.com
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new coding style rules and fix appeared issues.
JerryScript-DCO-1.0-Signed-off-by: Andrey Shitov a.shitov@samsung.com