Add promise rejection tracker support #4012
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
rerobika
added
api
|
Related feature request: #2931 . |
|
I feel like it would be better to handle this as a port function instead of a callback that can be set via the API. |
galpeter
reviewed
Jul 20, 2020
| TEST_ASSERT (jerry_get_error_type (last_rejected_reason) == JERRY_ERROR_TYPE); | ||
| jerry_release_value (last_rejected_promise); | ||
| jerry_release_value (last_rejected_reason); | ||
|
|
There was a problem hiding this comment.
There should be also a test where the "global" reject handler is not invoked as the reject was handled already.
| @@ -30,8 +30,11 @@ static const jerry_char_t test_source[] = TEST_STRING_LITERAL ( | |||
| ); | |||
|
|
|||
| static int count_in_assert = 0; | |||
| static int tracter_counter = 0; | |||
There was a problem hiding this comment.
What does "tracter" mean?
|
|
||
| **Summary** | ||
|
|
||
| Register a promise rejection tracker callback for the engine. |
There was a problem hiding this comment.
We should provide more details here imho and also mention the HostPromiseRejectionTracker from the standard here.
|
The PR should be reworked as a port function, so closing the PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu