Fix ReferenceError for let/const variables in of/in for loop #3885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you provide a simple example for the issue? I would not mind adding the test case to jerry tests as well, since if we move to another test262 hash, these tests might change. |
rwalczyna
force-pushed
the
FixLetReferenceError
branch
from
b45ac77 to
75606dd
Compare
|
You are right, test262 repository is external, so it might be changed. I have added test to es2015 directory. |
zherczeg
reviewed
Jun 10, 2020
jerry-core/parser/js/js-scanner.c
Outdated
| @@ -2108,7 +2108,7 @@ scanner_scan_statement_end (parser_context_t *context_p, /**< context */ | |||
| while ((literal_p = (lexer_lit_location_t *) parser_list_iterator_next (&literal_iterator)) != NULL) | |||
| { | |||
| if ((literal_p->type & (SCANNER_LITERAL_IS_LET | SCANNER_LITERAL_IS_CONST)) | |||
| && literal_p->type & SCANNER_LITERAL_NO_REG) | |||
| && (literal_p->type & (SCANNER_LITERAL_NO_REG | SCANNER_LITERAL_IS_USED))) | |||
There was a problem hiding this comment.
Based on SCAN_STACK_BINDING_INIT, I think SCANNER_LITERAL_IS_USED should be enough alone.
ReferenceError should be thrown when variable is used before assignment JerryScript-DCO-1.0-Signed-off-by: Rafal Walczyna r.walczyna@samsung.com
rwalczyna
force-pushed
the
FixLetReferenceError
branch
from
75606dd to
6f206bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReferenceError should be thrown when variable is used before assignment.
JerryScript-DCO-1.0-Signed-off-by: Rafal Walczyna r.walczyna@samsung.com