Skip to content

Fix initializer detection in for-in expressions. #3884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

zherczeg
Copy link
Member

@zherczeg zherczeg commented Jun 9, 2020

Also fix column update when comments are parsed.

Fixes #3882

Also fix column update when comments are parsed.

Fixes jerryscript-project#3882

JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rerobika rerobika requested a review from dbatyai June 9, 2020 13:15
@rerobika rerobika added the bug Undesired behaviour label Jun 9, 2020
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai merged commit 1bf52f5 into jerryscript-project:master Jun 10, 2020
@zherczeg zherczeg deleted the fix_destr_bind branch June 10, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion context_p->next_scanner_info_p->type == SCANNER_TYPE_FUNCTION
3 participants