Skip to content

Compiled code should hold strong reference for the object in the tagged template literal collection #3876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

rerobika
Copy link
Member

@rerobika rerobika commented Jun 8, 2020

This patch fixes #3866.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu

@rerobika rerobika added the bug Undesired behaviour label Jun 8, 2020
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rerobika rerobika changed the title Compiled code should hold string reference for the object in the tagged template literal collection Compiled code should hold strong reference for the object in the tagged template literal collection Jun 8, 2020
…ed template literal collection

This patch fixes jerryscript-project#3866.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zherczeg zherczeg merged commit dba9533 into jerryscript-project:master Jun 9, 2020
@rerobika rerobika deleted the fix_issue_3866 branch June 16, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

heap-use-after-free in ecma_ref_object
3 participants