Implement String.prototype.localeCompare function #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ret_value); | ||
|
|
||
| ecma_string_t *this_string_p = ecma_get_string_from_completion_value (this_to_string_val); | ||
| ecma_string_t *arg_string_p = ecma_get_string_from_completion_value (arg_to_string_val); |
There was a problem hiding this comment.
The this_to_string_val and arg_to_string_val are not completion values. They are ecma_value_t-s
There was a problem hiding this comment.
Oops, you're right, I've fixed it.
Thanks.
bzsolt
force-pushed
the
string_prototype_localecompare
branch
from
474a805 to
fefc0c1
Compare
JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély zsborbely.u-szeged@partner.samsung.com
bzsolt
force-pushed
the
string_prototype_localecompare
branch
from
fefc0c1 to
f15fdae
Compare
25 tasks
|
looks good to me |
|
Looks good to me |
|
Good to me |
egavrin
added
ecma builtins
|
Merged at f625473 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély zsborbely.u-szeged@partner.samsung.com