Implement builtin setters for Date object #367
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egavrin
added
ecma builtins
| extern ecma_completion_value_t ecma_date_set_internal_property (ecma_value_t this_arg, | ||
| ecma_number_t day, | ||
| ecma_number_t time, | ||
| bool input_is_utc); |
szledan
force-pushed
the
date_prototype_setters
branch
from
da710f2 to
3171b34
Compare
50 tasks
| * Used by: | ||
| * - All Date.prototype.set* routine except Date.prototype.setTime. | ||
| * | ||
| * @return completion value |
There was a problem hiding this comment.
@szledan, usually, completion values are returned by specification-defined routines. In the cases, content of completion value is clear, while content of this function's completion is not - without looking into its code.
Could you, please, extend the comment with note about what value is returned from the function, or with a reference to specification, so that origin of the value becomes clear?
|
After updating the comment the changes would look good to me. |
JerryScript-DCO-1.0-Signed-off-by: Szilard Ledan szledan.u-szeged@partner.samsung.com
szledan
force-pushed
the
date_prototype_setters
branch
from
3171b34 to
873987d
Compare
|
looks good to me |
|
@ruben-ayrapetyan recheck it please, and I'll merge it if its OK |
|
Looks good to me |
|
Merged at 005eb04 |
This was referenced Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Szilard Ledan szledan.u-szeged@partner.samsung.com