Implement builtin getters for Date object #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egavrin
added
ecma builtins
| \ | ||
| /* 1. */ \ | ||
| ECMA_TRY_CATCH (value, ecma_builtin_date_prototype_get_time (this_arg), ret_value); \ | ||
| ecma_number_t *this_num = ecma_get_number_from_value (value); \ |
szledan
force-pushed
the
date_prototype_getters
branch
2 times, most recently
from
5a74628 to
9b33cdd
Compare
50 tasks
|
Hi, I've updated this PR. |
|
Good to me. |
|
Could you add some tests? Otherwise the patch looks good. |
|
Sure |
szledan
force-pushed
the
date_prototype_getters
branch
from
9b33cdd to
468182e
Compare
|
lgtm |
|
|
JerryScript-DCO-1.0-Signed-off-by: Szilard Ledan szledan.u-szeged@partner.samsung.com
szledan
force-pushed
the
date_prototype_getters
branch
from
468182e to
8d7cdeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Szilard Ledan szledan.u-szeged@partner.samsung.com