Implement String.prototype.charAt() #320
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
|
|
||
| // check undefined | ||
| assert("hello world!".charAt(undefined) === "h"); | ||
|
|
There was a problem hiding this comment.
Please add test case for boolean arguments also.
|
Good to me. |
lvidacs
force-pushed
the
string_prototype_charat
branch
from
02bf718 to
de5d77f
Compare
|
Thanks for the review, boolean tests added. |
|
LGTM |
| ecma_string_t *original_string_p = ecma_get_string_from_value (to_string_val); | ||
| const ecma_length_t len = ecma_string_get_length (original_string_p); | ||
|
|
||
| /* 3 */ |
There was a problem hiding this comment.
Could you, please, clarify why step 4 is performed before step 3?
JerryScript-DCO-1.0-Signed-off-by: Laszlo Vidacs lvidacs.u-szeged@partner.samsung.com
lvidacs
force-pushed
the
string_prototype_charat
branch
from
de5d77f to
59ad6d9
Compare
|
@ruben-ayrapetyan: The order is changed to follow the standard, thanks for the comment. |
|
|
|
Rebased & merged: 632618d |
|
@galpeter lets move to branches - since this PR wasn't automatically closed. Again. |
|
@egavrin we could move to branches but not all of us have rights to create branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Laszlo Vidacs lvidacs.u-szeged@partner.samsung.com