Introduce new Promise API methods #3186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galpeter
added
ecma builtins
|
Documentation will be added a bit later. First I would like to get a feedback on the API. |
|
I support this idea! +1 |
|
The new functions look reasonable, I support this as well. |
galpeter
force-pushed
the
api_promise_new
branch
from
100f895 to
928e7bb
Compare
galpeter
changed the title
galpeter
force-pushed
the
api_promise_new
branch
2 times, most recently
from
58e8bbe to
0080c31
Compare
|
I've rebased and updated the PR with docs. |
rerobika
requested changes
Oct 24, 2019
The new API methods make it possible to get a Promise object's result and it's state. JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com
galpeter
force-pushed
the
api_promise_new
branch
from
0080c31 to
51b7752
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new API methods make it possible to get a Promise object's
result and it's state.