Skip to content

Implement String.prototype.substring() #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Implement String.prototype.substring() #318

wants to merge 1 commit into from

Conversation

lvidacs
Copy link
Contributor

@lvidacs lvidacs commented Jul 6, 2015

JerryScript-DCO-1.0-Signed-off-by: Laszlo Vidacs lvidacs.u-szeged@partner.samsung.com

@lvidacs
Implement String.prototype.substring()
5ca62c4 
JerryScript-DCO-1.0-Signed-off-by: Laszlo Vidacs lvidacs.u-szeged@partner.samsung.com
@lvidacs lvidacs mentioned this pull request Jul 6, 2015
Closed
@lvidacs
Copy link
Contributor Author

lvidacs commented Jul 6, 2015

See history in PR #244

@galpeter
Copy link
Contributor

galpeter commented Jul 6, 2015

lgtm

@egavrin
Copy link
Contributor

egavrin commented Jul 7, 2015

Good to me

@egavrin egavrin added this to the ECMA builtins milestone Jul 7, 2015
@egavrin egavrin added ecma builtins Related to ECMA built-in routines development Feature implementation labels Jul 7, 2015
@galpeter
Copy link
Contributor

galpeter commented Jul 8, 2015

Rebased & merged: 6d86c4b

@galpeter galpeter closed this Jul 8, 2015
@ILyoan ILyoan mentioned this pull request Jul 8, 2015
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lvidacs lvidacs

Labels
development Feature implementation ecma builtins Related to ECMA built-in routines
Projects
None yet
Milestone
ECMA builtins
Development

Successfully merging this pull request may close these issues.
3 participants
@lvidacs @galpeter @egavrin