Add new check for a special corner case to typedarray lastIndexOf #3156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerobika
requested changes
Sep 24, 2019
jerry-core/ecma/builtin-objects/typedarray/ecma-builtin-typedarray-prototype.c
Outdated
Show resolved
Hide resolved
szilagyiadam
force-pushed
the
fix_3129
branch
from
1affd7d to
b252eba
Compare
rerobika
requested changes
Sep 24, 2019
| if (!ecma_number_is_nan (num_var) | ||
| && is_last_index_of | ||
| && num_var < 0 | ||
| && (uint32_t) abs((int) num_var) > length) |
There was a problem hiding this comment.
This is a bit complicated. Isn't the num_var > length check enough here?
There was a problem hiding this comment.
Not really, because if the second argument is negative, than the normalized index is calculated this way: norm_index = length - abs (from_index). And since we return with uint32_t in the array_index_normalize method, if this negative argument's absolute value is greater than the length, the norm_index itself becomes negative, and this will result an underflow. So if we know, that the second argument is negative, and its absolute value is greater then the length, we should return -1, but if this absolute value is less then the length, we could calculate with it.
szilagyiadam
force-pushed
the
fix_3129
branch
from
b252eba to
096c956
Compare
Fixes jerryscript-project#3129 We need to check if we use the lastIndexOf method and if the second argument is a number, negative, and its absolute value is bigger than the length, then we should return with -1. JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu
szilagyiadam
force-pushed
the
fix_3129
branch
from
096c956 to
ef0d06c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3129
We need to check if we use the lastIndexOf method and if the second
argument is a number, negative, and its absolute value is bigger
than the length, then we should return with -1.
JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu