Fix length check for typedarray copyWithin #3108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szilagyiadam
force-pushed
the
fixing_3107
branch
from
e86ae12 to
b30fea7
Compare
dbatyai
requested changes
Sep 13, 2019
| @@ -1891,7 +1891,7 @@ ecma_builtin_typedarray_prototype_copy_within (ecma_value_t this_arg, /**< this | |||
| int32_t offset = (int32_t) (length - target); | |||
| int32_t count = JERRY_MIN (distance, offset); | |||
|
|
|||
| if (target >= length || start >= length || end == 0) | |||
| if (target >= length || start >= length || end == 0 || start >= end) | |||
There was a problem hiding this comment.
Shouldn't the start >= length condition just be replaced with start >= end? It seems to me that end is always <= length.
There was a problem hiding this comment.
Thats a good point, i will fix it!
|
The commit message could also be a bit more specific about what kind of check is being added. |
szilagyiadam
force-pushed
the
fixing_3107
branch
from
b30fea7 to
f65961a
Compare
szilagyiadam
changed the title
rerobika
requested changes
Sep 16, 2019
We should check if the start index is equal or greater than the end index, if thats the case, we should return with the original typedArray. Fixes jerryscript-project#3107 JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu
szilagyiadam
force-pushed
the
fixing_3107
branch
from
f65961a to
877b5fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should check if the start index is equal or greater than the end index,
if thats the case, we should return with the original typedArray.
Fixes #3107
JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu