Skip to content

Parse rest function arguments in the pre-scanner. #3099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zherczeg
Copy link
Member

Fixes #3097.

Note: this code is adapted from another work in progress patch.

@zherczeg zherczeg force-pushed the rework_argument_scanning branch 2 times, most recently from 6fd7fdb to bed6e5b Compare September 12, 2019 13:58
Fixes jerryscript-project#3097.

JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
@zherczeg zherczeg force-pushed the rework_argument_scanning branch from bed6e5b to 6399702 Compare September 12, 2019 14:39
@zherczeg zherczeg added bug Undesired behaviour critical Raises security concerns labels Sep 12, 2019
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rerobika rerobika merged commit 376cfea into jerryscript-project:master Sep 12, 2019
@zherczeg zherczeg deleted the rework_argument_scanning branch September 12, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behaviour critical Raises security concerns
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion context_p->token.type != LEXER_COLON in parser_parse_case_statement
3 participants