Add functions for iterating utf-8 strings #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sand1k
added
ecma core
| @@ -25,15 +25,81 @@ | |||
| #define LIT_BYTE_NULL (0) | |||
|
|
|||
| /** | |||
| * For the formal definition of Unicode transformation formats (UTF) see Section 3.9, Unicode Encoding Forms in The | |||
| * Unicode Standard (http://www.unicode.org/versions/Unicode7.0.0/ch03.pdf#G7404, tables 3-6, 3-7). | |||
There was a problem hiding this comment.
Why do you use Unicode 7.0? Since @ruben-ayrapetyan used data from Unicode 3.0 tables, should we regenerate them for 7.0?
There was a problem hiding this comment.
"ECMAScript source text is represented as a sequence of characters in the Unicode character encoding, version 3.0 or later."
Definitions in this file are the same for both Unicode 3.0 and 7.0.
We can change this link to 3.0.
| 0, | ||
| buf_size, | ||
| { | ||
| 0, |
There was a problem hiding this comment.
Initial offset of iterator is 0.
|
I have some comments for the names. But anything is good for me. |
|
@sand1k please update naming and |
Merged
sand1k
force-pushed
the
Andrey-ut8-string-iterators
branch
from
9ad76ba to
4375ad0
Compare
JerryScript-DCO-1.0-Signed-off-by: Andrey Shitov a.shitov@samsung.com
sand1k
force-pushed
the
Andrey-ut8-string-iterators
branch
from
4375ad0 to
ae3eea8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions provide the following:
lit_utf8_iterator_read_next,lit_utf8_iterator_read_next_and_incr,lit_utf8_iterator_incr.lit_utf8_iterator_read_prev,lit_utf8_iterator_read_prev_and_decr,lit_utf8_iterator_decr.lit_utf8_iterator_get_pos,lit_utf8_iterator_restore_pos.lit_utf8_iterator_get_index.lit_utf8_iterator_is_eos,lit_utf8_iterator_is_bos.lit_utf8_iterator_set_to_bos,lit_utf8_iterator_set_to_eos.