Skip to content

Added 'instanceof' binary operation to the API #2751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2019
Merged

Added 'instanceof' binary operation to the API #2751

merged 1 commit into from
Feb 13, 2019

Conversation

LaszloLango
Copy link
Contributor

JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com

@LaszloLango LaszloLango added api Related to the public API development Feature implementation labels Feb 7, 2019
@LaszloLango LaszloLango added this to the Release 2.0 milestone Feb 7, 2019
rerobika
rerobika approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (informal) after fixing this minor style issue.

galpeter
galpeter reviewed Feb 7, 2019
View reviewed changes
Copy link
Contributor

@galpeter galpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK the PR name is misleading, this is not a new API function just an extension/addition to an existing one.

@LaszloLango
Copy link
Contributor Author

@galpeter good catch, the commit message also wrong. I'll fix it.

@LaszloLango LaszloLango changed the title Added new 'jerry_value_instanceof' API function. Added 'instanceof' binary operation to the API Feb 8, 2019
galpeter
galpeter reviewed Feb 8, 2019
View reviewed changes
@LaszloLango
Added 'instanceof' binary operation to the API
c55617c 
Added 'JERRY_BIN_OP_INSTANCEOF' to 'jerry_binary_operation_t' and
'jerry_binary_operation'. Added unit tests for this new operation
and updated the documentations.

JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
zherczeg
zherczeg approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

galpeter
galpeter approved these changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@galpeter galpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LaszloLango LaszloLango merged commit 2d16705 into jerryscript-project:master Feb 13, 2019
@LaszloLango LaszloLango mentioned this pull request Feb 19, 2019
Merged
@zherczeg zherczeg mentioned this pull request Mar 19, 2019
Closed
@LaszloLango LaszloLango deleted the add-instanceof-api-2 branch March 29, 2019 07:58
@LaszloLango LaszloLango mentioned this pull request Apr 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zherczeg zherczeg zherczeg approved these changes

@galpeter galpeter galpeter approved these changes

@rerobika rerobika rerobika approved these changes

Assignees
No one assigned
Labels
api Related to the public API development Feature implementation
Projects
None yet
Milestone
Release 2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@LaszloLango @zherczeg @galpeter @rerobika