-
Notifications
You must be signed in to change notification settings - Fork 683
Add parallel test262 runner. #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
usage ;; | ||
esac | ||
done | ||
declare -a CHAPTERS_TO_TEST=("ch06" "ch07" "ch08" "ch09" "ch10" "ch11" "ch12" "ch13" "ch14") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ch15?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LaszloLango ah, sorry ^_^
What is the point of this script? Why we need it? |
85916eb
to
878852b
Compare
@LaszloLango for internal usage. It runs test262 much faster than the official runner. In short, it simplifies analysis of test262 issues. |
|
||
function usage() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the current usage of this script? We should write a comment at the beginning of this file at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add like in #206
6d539f7
to
9539909
Compare
@LaszloLango fixed, please check |
echo " 3rd parameter: (optional) call this script with the '--sub-chapters' flag to print the detailed report." | ||
echo "" | ||
echo "Example:" | ||
echo " ./run-test-suite-test262.sh <engine> <test262_dir> --detail" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe copy&paste error. I think --detail
is not a valid option. Change to --sub-chapters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIxed.
Good to me, but 3s for timeout may be too optimistic :) |
9539909
to
c0b9927
Compare
@LaszloLango PR was updated. I increased timeout to 5s ^_^ |
@egavrin, ok. still looks good to me. I have no other comments |
@LaszloLango great! Thank you. |
JerryScript-DCO-1.0-Signed-off-by: Evgeny Gavrin e.gavrin@samsung.com
c0b9927
to
1b55630
Compare
Looks good to me |
JerryScript-DCO-1.0-Signed-off-by: Evgeny Gavrin e.gavrin@samsung.com