Skip to content

Add parallel test262 runner. #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2015
Merged

Add parallel test262 runner. #275

merged 1 commit into from
Jul 1, 2015

Conversation

egavrin
Copy link
Contributor

@egavrin egavrin commented Jun 30, 2015

JerryScript-DCO-1.0-Signed-off-by: Evgeny Gavrin e.gavrin@samsung.com

@egavrin egavrin added enhancement An improvement infrastructure Related to GH Actions or the tested targets labels Jun 30, 2015
@egavrin egavrin added this to the Core ECMA features milestone Jun 30, 2015
usage ;;
esac
done
declare -a CHAPTERS_TO_TEST=("ch06" "ch07" "ch08" "ch09" "ch10" "ch11" "ch12" "ch13" "ch14")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ch15?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LaszloLango ah, sorry ^_^

@LaszloLango
Copy link
Contributor

What is the point of this script? Why we need it?

@egavrin egavrin force-pushed the parallel-test-runner-dev branch from 85916eb to 878852b Compare June 30, 2015 10:38
@egavrin
Copy link
Contributor Author

egavrin commented Jun 30, 2015

@LaszloLango for internal usage. It runs test262 much faster than the official runner. In short, it simplifies analysis of test262 issues.

@LaszloLango LaszloLango changed the title Add test262 runner. Add parallel test262 runner. Jun 30, 2015

function usage() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the current usage of this script? We should write a comment at the beginning of this file at least.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add like in #206

@egavrin egavrin assigned LaszloLango and unassigned galpeter Jun 30, 2015
@egavrin egavrin force-pushed the parallel-test-runner-dev branch 4 times, most recently from 6d539f7 to 9539909 Compare June 30, 2015 19:16
@egavrin
Copy link
Contributor Author

egavrin commented Jun 30, 2015

@LaszloLango fixed, please check

echo " 3rd parameter: (optional) call this script with the '--sub-chapters' flag to print the detailed report."
echo ""
echo "Example:"
echo " ./run-test-suite-test262.sh <engine> <test262_dir> --detail"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe copy&paste error. I think --detail is not a valid option. Change to --sub-chapters

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIxed.

@LaszloLango
Copy link
Contributor

Good to me, but 3s for timeout may be too optimistic :)

@egavrin egavrin force-pushed the parallel-test-runner-dev branch from 9539909 to c0b9927 Compare July 1, 2015 07:04
@egavrin
Copy link
Contributor Author

egavrin commented Jul 1, 2015

@LaszloLango PR was updated. I increased timeout to 5s ^_^

@LaszloLango
Copy link
Contributor

@egavrin, ok. still looks good to me. I have no other comments

@egavrin
Copy link
Contributor Author

egavrin commented Jul 1, 2015

@LaszloLango great! Thank you.
@ruben-ayrapetyan please check it again.

JerryScript-DCO-1.0-Signed-off-by: Evgeny Gavrin e.gavrin@samsung.com
@egavrin egavrin force-pushed the parallel-test-runner-dev branch from c0b9927 to 1b55630 Compare July 1, 2015 12:20
@ruben-ayrapetyan
Copy link
Contributor

Looks good to me

@egavrin egavrin merged commit 1b55630 into master Jul 1, 2015
@egavrin egavrin deleted the parallel-test-runner-dev branch July 1, 2015 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement infrastructure Related to GH Actions or the tested targets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants